GithubReleasesUpdateInformation::buildUrl is writing to the console
I'm working on a C# (#203) port of the Updater class which handles different log levels. This part of the code writes directly to the console which it probably should not.
https://github.com/AppImage/AppImageUpdate/blob/2708f91c9ba86eefbc3f13e666cc3356ab9a21a9/src/updateinformation/GithubReleasesZsyncUpdateInformation.h#L42
Clearly committed by accident. Could you send a PR, please?
This actually made me aware of the behaviour that checking for updates will fetch the update information twice which might lead to a temporary timeout from the api (happened to me a few times already): https://github.com/AppImage/AppImageUpdate/blob/2708f91c9ba86eefbc3f13e666cc3356ab9a21a9/src/updater.cpp#L178-L206
// validate AppImage
try {
validateAppImage(); // <-- first time
try {
auto updateInformationPtr = makeUpdateInformation(rawUpdateInformation);
const auto zsyncUrl = updateInformationPtr->buildUrl(makeIssueStatusMessageCallback()); // <-- second time
Would it be feasible to set zsyncUrl in the constructor ?