AppImageKit icon indicating copy to clipboard operation
AppImageKit copied to clipboard

README: Adding ExternalProject_Add example

Open thopiekar opened this issue 7 years ago • 9 comments

Added a short description how I added AppImageKit in one of my projects.

thopiekar avatar Feb 11 '18 15:02 thopiekar

@TheAssassin as our CMake artist in residence, does this "speak" to you? (For me, the many variables that CMake seems to use everyone makes it hard to understand what it is doing.)

probonopd avatar Feb 11 '18 15:02 probonopd

Looks quite a bit cryptic to me, too. I'll have a detailed look next week.

TheAssassin avatar Feb 11 '18 15:02 TheAssassin

Oops, I thought you merged the PR already. I forgot you have permissions to push into my branches if they are used for PRs 😅

thopiekar avatar Feb 11 '18 18:02 thopiekar

So, I suppose this is about building appimagetool and using it in your project, rather than using our (relatively new) libappimage? I'll clarify that a bit then in the README.

TheAssassin avatar Feb 11 '18 18:02 TheAssassin

Ok, feel free to do that. No, I'm not using the libappimage, but I guess it should be easy to prevent CMake to generate Makefiles, which build only libappimage 😉

thopiekar avatar Feb 11 '18 23:02 thopiekar

I'm confused on what the PR actually does?

luzpaz avatar Nov 19 '18 14:11 luzpaz

Yes, SetProjectDependencies is custom and the BUILD_OS_LINUX variable as well.

thopiekar avatar Nov 19 '18 16:11 thopiekar

This PR has been closed by the original author. No need for reviews or anything.

TheAssassin avatar Nov 19 '18 19:11 TheAssassin

Unexpected side effect of renaming of master branch. Sorry for the noise. Changing base and reopening.

TheAssassin avatar Dec 23 '18 14:12 TheAssassin