AppImageKit icon indicating copy to clipboard operation
AppImageKit copied to clipboard

Fix/wrong architecture string on appimagetool arch/1114

Open azubieta opened this issue 5 years ago • 6 comments

Allows using armhf and aarch64 as architecture names on appimagetool. Doesn't remove the old names ("arm", "arm_aarch64") to avoid breaking scripts of possible users.

Closes #1114

azubieta avatar Feb 10 '21 21:02 azubieta

Why do you want to hardcode pathToMksquashfs = "/usr/bin/mksquashfs";?

I think this breaks bundling mksquashfs privately?

probonopd avatar Feb 10 '21 21:02 probonopd

Why do you want to hardcode

Ups, that's wrong. It should be fixed now

azubieta avatar Feb 10 '21 21:02 azubieta

Should I proceed with the merge?

azubieta avatar Feb 11 '21 19:02 azubieta

Lgtm. @TheAssassin?

probonopd avatar Feb 11 '21 19:02 probonopd

Is this still a thing? @TheAssassin wdyt?

probonopd avatar May 06 '22 19:05 probonopd

I totally agreed "arm_aarch64" is misleading, and the command-line help message doesn't provide this information, you have to look into the source code to find it.

hyh19962008 avatar Aug 07 '22 04:08 hyh19962008