AppImageKit icon indicating copy to clipboard operation
AppImageKit copied to clipboard

Add zstd and Xcompression-level support

Open ambyjkl opened this issue 5 years ago • 2 comments

Resolves #478

I've actually not tested this yet. Please let me know if this is what you're looking for.

ambyjkl avatar Nov 27 '20 11:11 ambyjkl

I've actually not tested this yet. Please let me know if this is what you're looking for.

I have no idea why you would submit a PR with untested code. It almost seems like you think we don't have the few minutes to write that code, but we have the time to test yours. At least you're honest, which is very much appreciated.

I didn't bother looking into it too deeply. There's more than just one workflow issue with this PR. I don't think it makes sense to review this any further.

TheAssassin avatar Dec 14 '20 14:12 TheAssassin

Sorry I never got the chance to circle back. @TheAssassin sorry you feel that way, I didn't mean this PR to be an insult. I've never worked with this codebase before and I'm as busy as you are. I just wanted to understand if I'm headed in the right direction, so I can continue. If you don't have the time to help, feel free to close the PR.

ambyjkl avatar Mar 23 '21 20:03 ambyjkl