AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[FR] Support More Android Version

Open Schoumi opened this issue 1 year ago • 2 comments

Description

AppFlowy support only the last six android (10-15) version and I don't see a reason why the app has such limitation. You let 13% of potential device out with this choice. With support throught android 6 you gain 10% potential users.

Impact

More user can use the app, More user won't have to trash perfectly working hardware due to app won't support their hardware anymore without any good reason

Additional Context

To do so you only have to change this line: https://github.com/AppFlowy-IO/AppFlowy/blob/main/frontend/appflowy_flutter/android/app/build.gradle#L55C1-L55C25 from value 29 to value 23.

The world would be better if we don't throw away perfectly functionnal device juste because developers don't want to put some minimal effort to support a maximum of devices.

Schoumi avatar Jan 05 '25 12:01 Schoumi

@Schoumi It’s not just about changing the minSdkVersion from 29 to 23. We rely on the permission checker and device info packages, which require a minSdkVersion of 29. Please refer to the following link:

  • https://github.com/AppFlowy-IO/AppFlowy/pull/6244
  • https://developer.android.com/reference/android/os/Build#getSerial()

LucasXu0 avatar Jan 06 '25 01:01 LucasXu0

@LucasXu0 If you don't use the device's serial, and you shouldn't, you don't have to change minSdkVersion to 29. And if the package force you to do so because some function you don't use require API 29, it is a bad package.

Schoumi avatar Jan 06 '25 11:01 Schoumi