Ifeanyichukwu Amajuoyi
Ifeanyichukwu Amajuoyi
> Already looks pretty good, one question though. > > Also, do you have any idea how we could solve the same issue for the async variant of the background...
> > Yea, I think we can extend the new `BackgroundProcessorBuilder` or provide a new builder for the async variant. But extending the new builder might be the better approach...
> Sounds good to me, although we might need to account for the fact that the two variants have slightly different type requirements (i.e., trait bounds). But I think we...
This PR is ready for another round of review.
> Did another round of review, will take another look once CI passes. Thank you very much for the review. I'll address all the feedbacks and update the PR.
CI still failing, fixing it.
> Thanks! You'll need to run `cargo fmt` on `lightning-background-processor/src/lib.rs` and make sure each commit builds fine. You can run this check locally with `./ci/check-each-commit.sh main`. It will do an...
> This needs a rebase now that #3509 was merged. Yes, I see the conflicts already. I'll fix that.
Sorry I've not been available. I'll be continuing work on this PR this weekend to address all the issues.
Had to clean up and squash the commits while fixing the CI error. May still need more work, but the PR is ready for another round of review.