Fix #731 corrects treatment of empty/boolean attributes in the html2ft function

[renatodamas]

close #731

---

name: Pull Request about: Propose changes to the codebase title: '[PR] ' labels: '' assignees: ''

---

Related Issue #731

Proposed Changes Change function html2ft so it can handle empty/boolean attributes

Types of changes What types of changes does your code introduce? Put an x in all the boxes that apply:

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist Go over all the following points, and put an x in all the boxes that apply:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.
• [x] I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information No additional information.

[gitnotebooks[bot]]

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/732

[jph00]

Thank you! :) Can you please add a test or example to the notebook, and then run nbdev_clean and nbdev_export to clean/sync the nb?

[renatodamas]

@jph00 a test case for boolean attributes was added, and the file components.py was updated using the commands nbdev_clean and nbdev_export. Please let me know if there are any other required actions. Best regards.

[jph00]

Thank you! :D

[renatodamas]

@jph00 sorry, I haven't commit the cleaning notebook file. I think now it's ok.