angular-ru-sdk icon indicating copy to clipboard operation
angular-ru-sdk copied to clipboard

fix: virtual table contain several values fix

Open al-mart opened this issue 3 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X] The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

al-mart avatar Aug 07 '22 13:08 al-mart

Codecov Report

Base: 82.68% // Head: 82.64% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (66e75fa) compared to base (8175c00). Patch coverage: 33.33% of modified lines in pull request are covered.

:exclamation: Current head 66e75fa differs from pull request most recent head 9092ef8. Consider uploading reports for the commit 9092ef8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
- Coverage   82.68%   82.64%   -0.04%     
==========================================
  Files         617      617              
  Lines        8749     8754       +5     
  Branches     1679     1679              
==========================================
+ Hits         7234     7235       +1     
- Misses       1435     1440       +5     
+ Partials       80       79       -1     
Flag Coverage Δ
cdk 80.11% <33.33%> (-0.05%) :arrow_down:
jest 80.83% <ø> (ø)
ngxs 96.63% <ø> (ø)
summary 82.64% <33.33%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/ngx-filter-viewer/ngx-filter-viewer.component.ts 13.92% <16.66%> (-0.95%) :arrow_down:
.../src/components/table-cell/table-cell.component.ts 9.27% <25.00%> (+0.09%) :arrow_up:
...ual-table/src/services/filterable/filter.worker.ts 93.22% <100.00%> (+0.05%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Aug 07 '22 13:08 codecov-commenter