exe icon indicating copy to clipboard operation
exe copied to clipboard

Assets from node_modules not included

Open kenmadev opened this issue 1 year ago • 1 comments

Describe the bug Assets bundling works fine in v2.x.x Because I have this json prop on my package.json

"pkg": {
    "assets": [
      "node_modules/header-generator/data_files/**/*"
    ],
  }

and since the old pkg was able to read it, it worked just fine. I think in v3.x.x the assets are not included properly into the bundled .exe. I'm getting ENOENT to the required files.

To Reproduce Install npm package header-generator. This package contains data_files assets folder that is required to function.

Expected behavior Assets should be able to be included in the bundled .exe file and do its normal behaviour

kenmadev avatar Jan 15 '25 08:01 kenmadev

Hey @kenmadev , thanks for the report. It looks like replacing this same functionality as seen in pkg would involve creating a virtual file system as laid out in this issue. I don't believe I will have the bandwidth to fix this in the immediate future. Until I either find the time or a PR is submitted, I recommend using v2.x.x.

AngaBlue avatar Jan 17 '25 05:01 AngaBlue