Andrew S. Rosen
Andrew S. Rosen
> There's currently no page on the VASP manual for vasprun.xml, so I'm guessing this will be deprecated in favor of the hdf5 file in coming releases Oh this is...
Oh that was smart! Thanks!! I'll check if is resolved with the monty update.
Looks like your PR didn't fix this one btw, @jmmshn. I'll have to dig into it later.
Thanks for the pointer, @jmmshn! Removing the `.as_dict()` method in `emmet.core.utils.ValueEnum` results in an `AttributeError`: ```python AttributeError: 'CrystalSystem' object has no attribute 'as_dict' ``` I'll dig into this later in...
@munrojm can you please re-open this? It won't let me do so. It needs to be reopened due to #974.
I think that your proposal makes sense, with updated documentation to reflect the "extras" needed for a given `Store`. From the list of dependencies shown though, it's not initially clear...
Makes sense re: fastapi, boto3, and mogogrant. I'd support their use as optional dependencies. Re: `pyzmq`, I think you may need to look at the `zmq` import, e.g. [here](https://github.com/materialsproject/maggma/blob/767a02481b8df4ca5a8e5a67348b588a8059a4c9/src/maggma/cli/distributed.py#L170).
Thanks! Makes sense!! I'm curious how one uses the file based stores in production though if multiple processes accessing the DB at the same time will cause issues (as is...
Also my assumption 😄 To uncharted territory we go!
Yup, will do so shortly. Thanks! On Wed, Jan 4, 2023 at 10:55 AM Meir Wahnon ***@***.***> wrote: > Hey @arosen93 > Can you open PR to add those according...