FreeShopNX icon indicating copy to clipboard operation
FreeShopNX copied to clipboard

Save old title keys and info if download fails

Open Huntereb opened this issue 7 years ago • 5 comments

If the downloading of info.json or FreeShopNX.txt fails, don't delete the files we already have.

Huntereb avatar Sep 11 '18 22:09 Huntereb

I'm uncertain the exact reason, but downloading the titles before the info.json causes the information not to refresh automatically. I was able to fix it by downloading the titles after the info, but that's certainly not a proper way of doing it.

Huntereb avatar Sep 13 '18 18:09 Huntereb

Keeping previous files in case of a download failure is a good ideas. I'll add it in my version. But the other commit just work around the real issue which is the loading algorithm that assume titles should be present in the info file no matter what, and the keys should be loaded after that, adding them to existing titles. I'm going to change that so this should not happen anymore, to handle the case that info fails to download.

ctxnop avatar Sep 27 '18 07:09 ctxnop

Not sure if this project is still alive with the recent changes to the CDN, but I have reverted the last commit as requested.

Huntereb avatar Sep 29 '18 22:09 Huntereb

I'm still working on it, so it's is still alive. But unfortunatly you may be right. I can't install any other title for now. Still not sure why, I have some strange behaviour. If you have any pointer to the CDN changes you are referring to, It would be appreciated that you share them.

Meanwhile, your change was merge in my fork: https://github.com/ctxnop/FreeShopNX/commit/42279eefdfd9cf50ea52386c2e4d799af015daf7

ctxnop avatar Sep 30 '18 09:09 ctxnop

Apparently any downloads from the CDN, even game updates, now rely on dauth for account authentication. We'd require some form of exploitation of Nintendo's server infrastructure in order to bypass this.

Huntereb avatar Sep 30 '18 14:09 Huntereb