clickhouse-operator icon indicating copy to clipboard operation
clickhouse-operator copied to clipboard

[QUESTION] Why empty settings is omitted as nil

Open ardenwick opened this issue 2 years ago • 0 comments

Hello team! I am customizing clickhouse-operator, where there is a need to generate interserver_http_host setting for each host, but the host.Settings field is nil by default, as seen here:

https://github.com/Altinity/clickhouse-operator/blob/df26023f32e2b1f4b6812635221546e0bf35fb43/pkg/model/chi/normalizer.go#L1423-L1427

in commit d372baff13c9df96ba60a567c01f19ab6352746d

Though I can simply un-comment it, but I am a afraid of breaking some other logic behind the commit. So why empty settings are omitted as nil here?

ardenwick avatar Feb 22 '24 10:02 ardenwick