clickhouse-backup icon indicating copy to clipboard operation
clickhouse-backup copied to clipboard

base64 encoded credentials string for remote_storage: gcp

Open navi86 opened this issue 3 years ago • 9 comments

this should allow to pass encoded string to "WithCredentialsJSON".

fix https://github.com/AlexAkulov/clickhouse-backup/issues/498

navi86 avatar Aug 17 '22 20:08 navi86

@navi86 looks fail https://github.com/AlexAkulov/clickhouse-backup/runs/7944825381?check_suite_focus=true#step:6:1465 to fix it create properly ./test/testflows/.env as described in ./test/testflows/README.md

source ./tests/testflow/.env
rm -fv ./test/testflows/clickhouse_backup/tests/snapshots/cli.py.cli.snapshot
python3 ./tests/testflows/regression.py --only="/clickhouse backup/cli/default config"

Slach avatar Aug 23 '22 02:08 Slach

@Slach thanks for info, I saw there is issue with tests, I am not able to run it locally, because

  1. "python3 ./tests/testflows/regression.py --only="/clickhouse backup/cli/default config"" doesn't start time to time, for instance, I can run command without any progress and wait about 20 minutes so I had to cancel and run it again when it finally starts.
                23ms              [bash] bash#
              4m 32s         ⟥    Exception: termios.error: (4, 'Interrupted system call')
              4m 32s         ⟥⟤ Error executing command, /clickhouse backup/docker-compose cluster/I list environment variables to show their values/executing command, error
              4m 32s       ⟥⟤ Error I list environment variables to show their values, /clickhouse backup/docker-compose cluster/I list environment variables to show their values, error
              4m 32s     ⟥⟤ Error docker-compose cluster, /clickhouse backup/docker-compose cluster, error
              4m 32s   ⟥⟤ Error clickhouse backup, /clickhouse backup, error
                         termios.error: (4, 'Interrupted system call')

Failing

✘ [ Error ] /clickhouse backup

you can notice that it was running almost 5 mins without any progress 2. tests are failed because docker-compose is not able to start clickhouse container due to permissions error chown: changing ownership of '/var/log/clickhouse-server': Permission denied I don't know how to run this tests locally because it seems it doesn't work on my pc at all.

navi86 avatar Aug 23 '22 12:08 navi86

chown: changing ownership of '/var/log/clickhouse-server': Permission denied I don't know how to run this tests locally because it seems it doesn't work on my pc at all.

Which OS do you use for run docker?

Slach avatar Aug 23 '22 15:08 Slach

image

Slach avatar Aug 23 '22 15:08 Slach

chown: changing ownership of '/var/log/clickhouse-server': Permission denied I don't know how to run this tests locally because it seems it doesn't work on my pc at all.

Which OS do you use for run docker?

MacOS and I am using lima instead Docker

navi86 avatar Aug 23 '22 15:08 navi86

did you install docker and docker-compose inside lima VM?

Slach avatar Aug 23 '22 16:08 Slach

did you install docker and docker-compose inside lima VM?

Yes, of course it's installed

navi86 avatar Aug 29 '22 16:08 navi86

tesflows still failed and #499 (comment) still not resolved

oh, ok, I will check today later

navi86 avatar Aug 30 '22 09:08 navi86

@Slach I don't see any coverage inside test_storage_outline regarding of non encoded string: https://github.com/AlexAkulov/clickhouse-backup/blob/master/test/testflows/clickhouse_backup/tests/cloud_storage.py#L91 I am not able to run tests because it simply doesn't work on mac. my changes is pretty small, could you run it and update file "cli.py.cli.snapshot" ?

navi86 avatar Aug 30 '22 23:08 navi86