APPinViewController icon indicating copy to clipboard operation
APPinViewController copied to clipboard

Missing colorizing the last dot

Open pmilanez opened this issue 12 years ago • 3 comments

During the process of defining the PIN or entering, the last dot is never painted because the code go fast do go back.

So I've changed the following calls: [self checkForEnteredPin];

To: [self performSelector:@selector(checkForEnteredPin) withObject:self afterDelay:0.5];

So now it have time to paint the last dot and make the user understand better what is happening.

What do you think?

pmilanez avatar Nov 08 '13 13:11 pmilanez

Yep, we are thinking about it now, but we also need to "block" UI/UX while waiting 0.5 secs to not receive keyboard input and other events. We'll submit new version in some days with this improvement. Thanks for the feedback!

Krivoblotsky avatar Nov 08 '13 13:11 Krivoblotsky

True true.. Thanks for your attention!

pmilanez avatar Nov 08 '13 13:11 pmilanez

For APPinViewcontroller in a fork, I used:

#pragma mark - Pin Code View Delegate
- (void)pinCodeView:(APPinView*)view didEnterPin:(NSString*)pinCode
{
    // Small Hack to give time to show the last entered number
    double delayInSeconds = 0.15;
    dispatch_time_t popTime = dispatch_time(DISPATCH_TIME_NOW, delayInSeconds * NSEC_PER_SEC);
    dispatch_after(popTime, dispatch_get_main_queue(), ^(void){

        view.pinCode = nil;

        //Verify case
        if (self.pinCodeToCheck != nil && !self.shouldResetPinCode) {
            [self verifyPinWithEntered:pinCode];
        } else if (self.pinCodeToCheck != nil && self.shouldResetPinCode) {
            [self changePinWithEntered:pinCode];
        } else {
            [self setEnteredPin:pinCode];
        }
    });
}

nicarq avatar Jul 30 '14 05:07 nicarq