Alt-F4 icon indicating copy to clipboard operation
Alt-F4 copied to clipboard

Audio Embed

Open Conor12345 opened this issue 4 years ago • 5 comments

Please test and lemme know if you can break it.

Conor12345 avatar May 16 '21 20:05 Conor12345

Is it possible to change the white to gray? The white is a bit drastic. I was thinking it would look nice if it was a darker gray than the background. But other than that it looks awesome :D

heinwessels avatar May 17 '21 11:05 heinwessels

yeah I will agree with what @heinwessels said.

it would be grate to have it look consistently across browsers

firefox image

safari image

besides that, from functional point it looks great

DrMagPie avatar May 17 '21 15:05 DrMagPie

So it looks like if we want to change the styling to be consistent, we have to start fresh and redefine the styling of the <audio> tag. (See https://stackoverflow.com/questions/4126708/is-it-possible-to-style-html5-audio-tag/4126871). This is probably beyond my js ability but if someone else can take a crack at it that would be awesome.

Another option would be to use something like http://www.jplayer.org/ which might make it a bit easier.

Conor12345 avatar May 23 '21 11:05 Conor12345

Not sure if we still need it. Can we close it? We can always reopen it again when we want.

heinwessels avatar Mar 10 '22 07:03 heinwessels

I believe that's for @Conor12345 to decide. As he is a "story" owner.

DrMagPie avatar Mar 16 '22 23:03 DrMagPie

Closing this PR as it clutters my Review Reqeusts page, and I'm pretty sure we're not going to merge it. We can always reopen it again if Conor wants to merge :)

heinwessels avatar Jan 02 '23 06:01 heinwessels