Alpine-DAV
Unique domain IDs
In PR #1196 a check was added for unique domain IDs. In PyFR, for simplicity, we have been setting the domain ID to f'domain_{rank}_{element type}'. However #1196 assumes that the domain IDs are int32s.
See: ascent_main_runtime.cpp, line: 638
The rendering of ascent still seems fine (ie it doesn't seem to care that the domain IDs are strings) but it throws a warning that the domain IDs aren't unique.
Would it be possible to support non-integer domain IDs in the unique domain checking?
Hi @WillTrojak,
While I expect its not 100% clear from the docs, domain_ids are optional but when present are expected o be integers. I don't think we have strict checks b/c they are optional.
Why integers? domain_ids are used in more advanced parts of the Mesh Blueprint for info like domains connect, or how AMR domains nest, etc.
If you want to use strings, is it possible to store those as something the blueprint won't try to interpret like domain_name instead of domain_id?
