AlphaConsoleElectron icon indicating copy to clipboard operation
AlphaConsoleElectron copied to clipboard

Javascript/HTML/CSS improvements

Open C-Lodder opened this issue 6 years ago • 11 comments

This is currently a draft PR. I will continue working on this if one of the maintainers agrees with the changes.

Changes so far:

  • Update dependencies
  • Start rewriting jQuery in vanilla JS
  • Start rewriting in ES6
  • Move JS from HTML to separate JS file
  • Move CSS from HTML to separate files
  • Improve performance
  • Remove unecessary code
  • Start utilising SVG's

C-Lodder avatar Feb 01 '20 23:02 C-Lodder

Hi @C-Lodder, these changes look great if you're interested in working on these :)

HaydenMeloche avatar Feb 02 '20 16:02 HaydenMeloche

Another thing I'd like to at some point is moving the CSS out of the HTML files as well

HaydenMeloche avatar Feb 02 '20 16:02 HaydenMeloche

@HaydenMeloche good news. I'll continue working on this tomorrow. And yeah I'll move the styling out into SCSS files and use Gulp to compile it. Need to do a fair bit of testing as the dependency updates were fairly big jumps

C-Lodder avatar Feb 02 '20 17:02 C-Lodder

@HaydenMeloche On the "Textures" page, should the download button work in a test environment?

C-Lodder avatar Feb 04 '20 14:02 C-Lodder

@C-Lodder As of right now we don't really have any 'test' environment really. The download button as of right now would just hit the same server our live application would

HaydenMeloche avatar Feb 06 '20 01:02 HaydenMeloche

Hmm, in which case that's the main feature that's not working. I'll continue looking into this today

C-Lodder avatar Feb 06 '20 09:02 C-Lodder

@HaydenMeloche I've take the PR out of draft and it's ready for review.

There's still a lot of jQuery code in the package, but I'll rewrite the rest of this in perhaps the next version

C-Lodder avatar Feb 06 '20 11:02 C-Lodder

@HaydenMeloche is there any update on this?

C-Lodder avatar Feb 27 '20 09:02 C-Lodder

hi @C-Lodder sorry, I'm out of my normal country at the moment for about another week or so. I can take a better look when I am back!

HaydenMeloche avatar Mar 01 '20 02:03 HaydenMeloche

Thanks for your hardwork!

HaydenMeloche avatar Mar 01 '20 02:03 HaydenMeloche

@HaydenMeloche @burnss9 I've reverted the config.json. If there's anything else that stands out, please let me know.

C-Lodder avatar Mar 01 '20 09:03 C-Lodder