AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

MathUtils: move BetheBlochAleph to a common header

Open ktf opened this issue 1 month ago • 6 comments

ktf avatar Dec 12 '25 12:12 ktf

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0 async-2024-PbPb-apass1 async-2024-ppRef-apass1 async-2024-PbPb-apass2 async-2023-PbPb-apass5

github-actions[bot] avatar Dec 12 '25 12:12 github-actions[bot]

The codechecker on ARM seems to complain about more stuff than on X86.

sawenzel avatar Dec 13 '25 15:12 sawenzel

Some of the checks depend on how the code is actually optimised, so that's architecture specific. PR updated with the fix.

ktf avatar Dec 15 '25 08:12 ktf

@wiechula @davidrohr could you sign off this as TPC? Why was this not part of the common utils?

ktf avatar Dec 15 '25 15:12 ktf

(or @shahor02, of course)

ktf avatar Dec 15 '25 15:12 ktf

To avoid breaking O2Physics. We can clean it up once merged.

ktf avatar Dec 23 '25 14:12 ktf

Is the error in dataflow:

Bulk-processing 2-prong Helix - Helix case
GPUassert: CUDA driver version is insufficient for CUDA runtime version /sw/SOURCES/O2/14918-slc9_x86-64/0/Common/DCAFitter/GPU/cuda/GPUInterface.cu 51
unknown location(0): [4;31;49mfatal error: in "DCAFitterNProngsBulk": std::runtime_error: GPU assert failed.[0;39;49m
/sw/SOURCES/O2/14918-slc9_x86-64/0/Common/DCAFitter/GPU/cuda/test/testDCAFitterNGPU.cxx(557): [1;36;49mlast checkpoint: "DCAFitterNProngsBulk" test entry[0;39;49m

a known issue?

ktf avatar Dec 24 '25 11:12 ktf

Is the error in dataflow:

Bulk-processing 2-prong Helix - Helix case
GPUassert: CUDA driver version is insufficient for CUDA runtime version /sw/SOURCES/O2/14918-slc9_x86-64/0/Common/DCAFitter/GPU/cuda/GPUInterface.cu 51
unknown location(0): �[4;31;49mfatal error: in "DCAFitterNProngsBulk": std::runtime_error: GPU assert failed.�[0;39;49m
/sw/SOURCES/O2/14918-slc9_x86-64/0/Common/DCAFitter/GPU/cuda/test/testDCAFitterNGPU.cxx(557): �[1;36;49mlast checkpoint: "DCAFitterNProngsBulk" test entry�[0;39;49m

a known issue?

Yes, I wrote on Mattermost to Sergio and you. It seems the dataflow container was changed, which enabled some GPU tests developed by Matteo. These tests never ran before, since the FullCI has ctests disabled to speed up the build. It seems these tests are generally broken, I tried locally on my system and they are failing as well.

https://github.com/AliceO2Group/AliceO2/pull/14935 disables them. Not merged yet since I discovered some more tests are failing and I want to get it fully clean.

We can merge the BetheBlockAleph PR if you like.

davidrohr avatar Dec 24 '25 11:12 davidrohr