ASoA: Apply rule of five
- Define missing special member functions from the rule of five.
- Declare move functions
noexcept. - Move assignment operator for
TableIteratornot defined as it cannot be defaulted.
REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-
+async-label <label1>, <label2>, !<label3> ...
This will add <label1> and <label2> and removes <label3>.
The following labels are available async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0 async-2024-PbPb-apass1 async-2024-ppRef-apass1 async-2024-PbPb-apass2 async-2023-PbPb-apass5
I am not sure this is a good idea. Have you checked with bloaty this change does not add to the already large number of symbols we have? Is this trying to solve an actual problem or you simply want to have the linter happy?
I am not sure this is a good idea. Have you checked with bloaty this change does not add to the already large number of symbols we have?
I haven't but I'm happy to check if you point me to instructions.
Is this trying to solve an actual problem or you simply want to have the linter happy?
Both.
- Implicitly deleted move constructors and move assignments prevent optimisations.
- When I run Clang-Tidy on O2Physics with the
cppcoreguidelines-special-member-functionscheck, I get thousands of errors from ASoA for all columns, which makes it harder to find errors related to classes in O2Physics.