Olivier Halligon
Olivier Halligon
Swift 3 support has landed last week, time to work on that now 😄
@arthurhammer any news on your side about if you think you could find some time to do a PR for it? Otherwise, @igorkulman don't hesitate to give it a try...
`size_t` is the official type for sizes in the CoreFoundation world. as methods like `CGPDFDocumentGetNumberOfPages` actually has a return type of `size_t`, that's why I exposed the same type in...
@mokagio I took the liberty to push a commit (https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1392/commits/665b15bd56ad4a0331c13f71045d693613486362) to fix the `testPaste{Image,Video}WithoutFormatting` test failures. [EDIT]I later fixed that commit 665b15b with c67821c[/EDIT] --- - I have searched the...
@mokagio Just also pushed https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1392/commits/90c0e4db1246dc4e87f004c4ec96061399447efb to fix the `testCopyAndPasteToPlainText` test failure on extra `\n`. ⚠️ That being said, while the test pass, I'm still not 100% sure why there was...
It seems like the test failures are due to the "Allow Paste" System Prompt—which now appears on the simulator in more recent iOS versions—during the copy/paste-related tests. @geriux @mokagio can...
> The warnings remain, I added `--allow-warnings` to the `pod` commands as a workaround. I don't see that `--allow-warnings` added to the pod commands in `.buildkite/` yet, so I'm guessing...
I actually looked quickly at Sorbet while I was working on the refactoring, as I was really annoyed by the lack of type-checking and the fragility of such a refactoring...
Seems that RBS, TypeProf and Sorbet are maturing and made promising progress as part of Ruby 3: - https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ - https://blog.appsignal.com/2021/01/27/rbs-the-new-ruby-3-typing-language-in-action.html Maybe worth revisiting those to see if we could...
Haven't taken the time to read that code yet (it's still in Draft after all, and there's no PR description yet to explain the idea behind 😛 ) but could...