Olivier Halligon

Results 378 comments of Olivier Halligon

@krodac I guess you didn't read about my comment on #66 and my pod [Reusable](https://github.com/AliSoftware/Reusable) library then :wink:

@phatblat Sounds good to me! Don't hesitate to piggy-back on #66 to discuss that and make it happen the way you just described!

The new reference PR to implement that is now https://github.com/SwiftGen/SwiftGenKit/issues/16

Hi @netbe The feature is still definitely in our roadmap, and we actually renamed the `storyboard` subcommand to `ib` in the latest 6.0 release, and rearranged the parsers in SwiftGenKit...

We already have warnings for old keys in config :) See related tests [here](https://github.com/SwiftGen/SwiftGen/blob/master/Tests/SwiftGenTests/ConfigReadTests.swift#L216-L291) Good point about introducing `swiftgen run` in 6.2.1 👍

Mmmh that's not what I seem to read in the source code though: to me it logs a warning message [every time it sees the `path` key](https://github.com/SwiftGen/SwiftGen/blob/develop/Sources/SwiftGen/Config/ConfigEntry.swift#L56), or [the `output`/`templateName`/`templatePath`/`params`...

![mindblown](https://user-images.githubusercontent.com/216089/42334352-5d653ea8-807d-11e8-885d-556aee432d6b.gif)

Didn't check the regexes, but from the looks of it, LGTM👌 You could also omit the "sender:" pay for the first rule so that it works even if that sender...

Also note that according to the documentation: 1) When we use [`init(red:green:blue:alpha:)`](https://developer.apple.com/documentation/uikit/uicolor/1621925-init), input values are never clamped to `0.0…1.0` when linked to iOS10+, meaning that values in `0.0…1.0` are in...

Yeah, I'd have to double-check but I'm pretty sure `*.clr` files support color spaces, so probably already P3 too.