OHAttributedLabel icon indicating copy to clipboard operation
OHAttributedLabel copied to clipboard
verified publisher icon AliSoftware

Added long press event & fixed memory leak

Open JonasGessner opened this issue 12 years ago • 2 comments

JonasGessner avatar Feb 05 '14 21:02 JonasGessner

Nice addition but two questions:

  • Why the enabled=NO then enabled=YES here?
  • Couldn't we mutualize some code about detection of the link under the tapped point between the tapGR and the longPressGR ?

A bit busy so won't have time to review it all until at least next WE anyway, please be patient ;)

AliSoftware avatar Feb 11 '14 21:02 AliSoftware

The enabled part is unnecessary. It is used to cancel a gesture recognizer but in this case it doesn't need to be cancelled.

About mutualizing code: Some mutualization would be possible but we are really just talking about a few lines of code so I think the code is fine like this.

JonasGessner avatar Feb 11 '14 21:02 JonasGessner