go2rtc icon indicating copy to clipboard operation
go2rtc copied to clipboard

Auto-restart go2rtc on error pattern

Open felipecrs opened this issue 3 years ago • 3 comments

I needed to increase the reliability of go2rtc by removing the need of manually restarting it in such error conditions.

  • This PR builds on #72
    • It has to be merged only after #72
  • Partially fixes #39 and partially fixes #87
    • We may need to add more error patterns
  • This is not a definitive solution. Ideally go2rtc should detect the issue by itself and do the needful to restart the stream without requiring to restart the whole app (which cause the Hass API from being unavailable for some seconds -- probably causing any player to error out)
    • Nevertheless this is better than the current approach, which should help until the definitive fix comes in

felipecrs avatar Oct 23 '22 19:10 felipecrs

chrome_hd9amuvoUH

felipecrs avatar Oct 23 '22 19:10 felipecrs

I switched the implementation a little, now the watchdog will only restart the go2rtc service rather than restarting the whole add-on/container, which should make the restart a lot faster.

felipecrs avatar Oct 23 '22 21:10 felipecrs

I don't use Docker myself, so looking forward to this enhancement making it to the regular binaries as well at some point :)

darethehair avatar Oct 23 '22 22:10 darethehair

  • This should not be needed anymore since #39 got resolved.

felipecrs avatar Nov 06 '22 23:11 felipecrs