SubtitlesParser icon indicating copy to clipboard operation
SubtitlesParser copied to clipboard
verified publisher icon AlexPoint

The TextWriter writer should not be closed in the WriteStream method

Open doggy8088 opened this issue 1 year ago • 1 comments

The WriteStream in the SrtWriter method might called multiple times. I think the TextWriter writer should not be closed early in this method.

https://github.com/AlexPoint/SubtitlesParser/blob/19ab8d31859e4556ee8adbe4649fe837d4522228/SubtitlesParser/Classes/Writers/SrtWriter.cs#L58-L72

doggy8088 avatar Feb 15 '24 19:02 doggy8088

Good catch! Indeed, the TextWriter object should be closed to avoid any issue. Could you submit a fix so that I can package a corrective version?

AlexPoint avatar Feb 25 '24 14:02 AlexPoint