LibMultiPart icon indicating copy to clipboard operation
LibMultiPart copied to clipboard

Remove hasInitializedFromRemote check in NET_KEY_PART reader

Open Kneelawk opened this issue 3 years ago • 1 comments

This PR

This PR removes the erroneous hasInitializedFromRemote check in the NET_KEY_PART decoder so that clients who've had their PartContainers initialized via part placement can still receive NET_KEY_PART packets.

Testing

~~This change has not been tested specifically on this branch,~~ but has been tested in the 0.8.x-1.19.x branch and has yielded the desired results. This is merely copying the change back to the 0.7.x-1.18.x branch. I have tested the change on this branch and verified that it indeed does fix the issue where new part data was not getting sent to the client.

Associated Issues

This PR fixes #56.

Kneelawk avatar Aug 31 '22 07:08 Kneelawk

Without this change, placing a part does not send any of the part's initialization packets to the client until the client re-logs.

Kneelawk avatar Oct 29 '22 23:10 Kneelawk

This still needs more investigation, but for the time being, this seems like the best say to fix this crippling issue.

Kneelawk avatar Jan 03 '23 00:01 Kneelawk