Alan Rominger
Alan Rominger
I started working on https://github.com/ansible/django-ansible-base/pull/337, but in doing so, I realized that this PR here is my primary concern. The change here adds several DAB authenticator-related endpoints. What is the...
Your test at `awx/main/tests/unit/models/test_survey_models.py` is good, but that handles an error case, and we need _more_ testing than this for a high-level feature like this. I want to see the...
Since this has gone so long without getting fixed, we could use this chance to updated the wording here: https://github.com/ansible/awx/blob/78fc23138a06d5db53a23e6b11b7f3e3e6f6efc5/awx_collection/plugins/module_utils/controller_api.py#L527
This is really hard to parse. My reading is that the job of this method is to extract the named component of the URL, and then call the method that...
Also reported in https://github.com/ansible/awx/issues/1997
This looks fine to serialize the relationships that exist inside of AWX. How does it save those relationships from somewhere else into the AWX database?
Also, I'm not sure where the "additional data" wording comes from, since nothing in the diff seems to refer to this.
Really quick 2 cents here - I also think the API change of a new `status` would be disruptive and prone to break things. Not something we want in the...
There are some other options to solve this problem, but I want to stress the point that it is _solvable_ and it should be solved. To clarify what problem this...
I'm wondering if a simpler solution might be to have `ansible-runner worker` add a timestamp to the started callback data. That could use epoch time, I don't know if it...