API-Examples-Web icon indicating copy to clipboard operation
API-Examples-Web copied to clipboard

adjustVideoProfile.js contains incorrect comments

Open yamasite opened this issue 4 years ago • 3 comments

The comment here applies to Web SDK 3.x only:

// you can find all the agora preset video profiles here https://docs.agora.io/cn/Voice/API%20Reference/web/interfaces/agorartc.stream.html#setvideoprofile
var videoProfiles = [
  { label: "480p_1", detail: "640×480, 15fps, 500Kbps", value: "480p_1" },
  { label: "480p_2", detail: "640×480, 30fps, 1000Kbps", value: "480p_2" },
  { label: "720p_1", detail: "1280×720, 15fps, 1130Kbps", value: "720p_1" },
  { label: "720p_2", detail: "1280×720, 30fps, 2000Kbps", value: "720p_2" },
  { label: "1080p_1", detail: "1920×1080, 15fps, 2080Kbps", value: "1080p_1" },
  { label: "1080p_2", detail: "1920×1080, 30fps, 3000Kbps", value: "1080p_2" },
  { label: "200×640", detail: "200×640, 30fps", value: { width: 200, height: 640, frameRate: 30 } } // custom video profile
]

The link for Web SDK 4.x is: https://docs.agora.io/cn/Video/API%20Reference/web_ng/globals.html#videoencoderconfigurationpreset

yamasite avatar Apr 19 '21 08:04 yamasite

thanks for report will check and update

yoreland avatar Apr 20 '21 00:04 yoreland

Also, the markdown files in the Docs folder are out of date and can just be removed. Otherwise, they might be misleading.

yamasite avatar Apr 20 '21 03:04 yamasite

Your comments will be included in next repo update. Thanks for your contribution!

yoreland avatar Apr 20 '21 07:04 yoreland