agenta icon indicating copy to clipboard operation
agenta copied to clipboard

[Bug Fix]: enhance image validation and app variant update logic for cloud-dev environment

Open aybruhm opened this issue 1 year ago • 2 comments

Description

This PR introduces enhancements to ensure that re-serving a variant in the cloud-dev environment works as expected.

Related Issue

Closes AGE-511

Changes Included:

  • Image Validation Logic Update:
    • In the cloud-dev environment, certain fields like workspace and organization are stripped off before validation, since they are not used during this process.
  • App Variant Update Enhancement:
    • In the cloud-ev environment, the organization relationship is now loaded when updating an app variant to ensure the model is fully refreshed in the session.

What to QA (in cloud-dev and oss)

  • App Creation from the CLI
    • Create and serve an app from the CLI
    • Navigate to the app playground URL to ensure that it is working
    • Update the app variant code/configuration and re-serve to see if the changes are reflected

Acceptance Tests

  • Ensure that app creating and re-serving from the CLI works
  • Ensure that app creation from the UI template works

aybruhm avatar Aug 18 '24 23:08 aybruhm

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 11:46pm
agenta-documentation ❌ Failed (Inspect) Aug 18, 2024 11:46pm

vercel[bot] avatar Aug 18 '24 23:08 vercel[bot]

Added to my QA todo list.

jp-agenta avatar Aug 19 '24 09:08 jp-agenta

What to QA (in cloud-dev and oss)

  • [x] App Creation from the CLI
  • [x] Create and serve an app from the CLI
  • [x] Navigate to the app playground URL to ensure that it is working
  • [x] Update the app variant code/configuration and re-serve to see if the changes are reflected

Acceptance Tests

  • [x] Ensure that app creating and re-serving from the CLI works
  • [x] Ensure that app creation from the UI template works

jp-agenta avatar Aug 19 '24 10:08 jp-agenta

Screenshot 2024-08-19 at 12 41 57 ☝️ requires fixing ?

jp-agenta avatar Aug 19 '24 10:08 jp-agenta

Screenshot 2024-08-19 at 12 41 57 ☝️ requires fixing ?

Nope, it doesn't.

aybruhm avatar Aug 19 '24 14:08 aybruhm