agenta icon indicating copy to clipboard operation
agenta copied to clipboard

[Enhancement]: Implemented endpoint for renaming an application

Open aybruhm opened this issue 1 year ago • 3 comments

Description

This PR introduces an endpoint to update an existing app, including the necessary backend logic and test cases.

Related Issue

Closes AGE-539

Changes Included:

  • Added a new update_app router to handle app update requests.
  • Implemented the update_app DB function to update app details in the database.
  • Added test cases to validate the update functionality.

What to QA

  • App Update via API:
    • Test the new update endpoint by updating an app’s details (e.g., name) and verify that the changes are correctly reflected in the database.
  • Error Handling:
    • Test edge cases like updating non-existent apps or providing invalid data and verify that appropriate errors are returned.

Acceptance Tests

  1. Create App:
    • Create an app from the UI or CLI
  2. Update App via API:
    • Send a request to the update app endpoint and confirm that the app’s details are updated correctly in the database.
  3. Test Case Validation:
    • Run the test suite to ensure that all test cases pass, including the new ones added for the update functionality.
  4. Error Handling Scenarios:
    • Verify that proper error messages are returned when invalid or incomplete data is provided in the update request.

aybruhm avatar Aug 16 '24 07:08 aybruhm

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 9:55am
agenta-documentation ❌ Failed (Inspect) Aug 19, 2024 9:55am

vercel[bot] avatar Aug 16 '24 07:08 vercel[bot]

Also, let's update the fern client SDK (it might make sense to add a github action for this @aakrem )

mmabrouk avatar Aug 18 '24 09:08 mmabrouk

Added to my QA todo list.

jp-agenta avatar Aug 19 '24 09:08 jp-agenta

What to QA

  • [x] Test the new update endpoint by updating an app’s details (e.g., name) and verify that the changes are correctly reflected in the database and it the WebUI.
  • [x] Test edge cases like updating non-existent apps (check) or providing invalid data (check) and verify that appropriate errors are returned.

Acceptance Tests

  • [x] Create an app from the UI or CLI
  • [x] Send a request to the update app API endpoint and confirm that the app’s details are updated correctly in the database.

jp-agenta avatar Aug 19 '24 10:08 jp-agenta

Screenshot 2024-08-19 at 13 12 44 ☝️ requires fixing ?

jp-agenta avatar Aug 19 '24 11:08 jp-agenta

Screenshot 2024-08-19 at 13 12 44 ☝️ requires fixing ?

Nope, it doesn't.

aybruhm avatar Aug 19 '24 14:08 aybruhm