adyen-php-api-library icon indicating copy to clipboard operation
adyen-php-api-library copied to clipboard
verified publisher icon Adyen

Mixed use of quotes

Open szepeviktor opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. Clean code uses only single quotes.

Describe the solution you'd like I'd send a PR with changing all quotes to single quotes.

Will you merge it?

szepeviktor avatar Jun 03 '21 07:06 szepeviktor

PHPCS has a rule for that <rule ref="Squiz.Strings.DoubleQuoteUsage.NotRequired"/>

szepeviktor avatar Jun 03 '21 07:06 szepeviktor

@szepeviktor sure, you can create the PR.

acampos1916 avatar Jun 04 '21 09:06 acampos1916

@jillingk I am very sad that a company like Adyen does not a follow a (any) coding standard. What do you think about it?

szepeviktor avatar Aug 17 '22 13:08 szepeviktor

Hi @szepeviktor,

First of all thanks for all the contributions and suggestions you have made, it's definitely much appreciated.

Since your last PR, we have internally aligned our coding standard a bit. However, I agree with you that this could use improvement and should also be more transparant! I will discuss this with the team as well and let you know the outcome.

Have a nice day!

Best, Jilling Adyen

jillingk avatar Aug 17 '22 13:08 jillingk

I was wrong. You follow PSR-2. But it does not include rules for quotes.

szepeviktor avatar Aug 17 '22 14:08 szepeviktor