Add logger

Open arihantbansal opened this issue 4 years ago • 4 comments

This PR resolves Issue #23.

Aug 27 '21 16:08 arihantbansal

Codecov Report

Merging #64 (c6ba6f0) into main (191a0a9) will decrease coverage by 4.08%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##              main      #64      +/-   ##
===========================================
- Coverage   100.00%   95.91%   -4.09%     
===========================================
  Files           17       19       +2     
  Lines          704      734      +30     
===========================================
  Hits           704      704              
- Misses           0       30      +30

Impacted Files	Coverage Δ
code_soup/utils/__init__.py	`0.00% <0.00%> (ø)`
code_soup/utils/logger.py	`0.00% <0.00%> (ø)`

Aug 27 '21 16:08 codecov[bot]

@arihantbansal Can you try implementing your logger in the GAN Tutorial notebook so we can merge it ?

Sep 02 '21 06:09 someshsingh22

@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR

Oct 11 '21 01:10 someshsingh22

@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR

I'll try fix the callback logging and implement it in the tutorial by EOD. What are the requirements for the tests?

Oct 11 '21 04:10 arihantbansal