AdiButtonAuras icon indicating copy to clipboard operation
AdiButtonAuras copied to clipboard

Will there be 10.0 update? Or the addon is dead?

Open mateuszgrochowski opened this issue 3 years ago • 26 comments

The game seems unplayable for me without it :(

mateuszgrochowski avatar Oct 27 '22 09:10 mateuszgrochowski

temp fix is in file \_retail_\Interface\AddOns\AdiButtonAurasAdiButtonAuras.toc comment #SMBH\lib.xml

in file \_retail_\Interface\AddOns\AdiButtonAuras\core\Core.lua comment

--hooksecurefunc('PetActionBar_Update', function()
--	for i = 1, NUM_PET_ACTION_SLOTS do
--		UpdateHandler('PetActionBar_Update', _G['PetActionButton'..i])
--	end
--end)
--hooksecurefunc('StanceBar_UpdateState', function()
--	for i = 1, NUM_STANCE_SLOTS do
--		UpdateHandler('StanceBar_UpdateState', _G['StanceButton'..i])
--	end
--end)

then go https://www.curseforge.com/wow/addons/libbuttonglow-1-0/download/4040423 download lib unpuk and replace same name libs in \_retail_\Interface\AddOns\AdiButtonAuras\libs

LibButtonGlow-1.0
LibStub

settings dont work, but glow work for me

SlivaNilow avatar Oct 27 '22 17:10 SlivaNilow

Made those exact changes but it's not working. No glow and many LUA errors.

mario-64 avatar Oct 27 '22 20:10 mario-64

Made those exact changes but it's not working. No glow and many LUA errors.

idk - why im repeat all steps on fresh install addon and it work for me may be some you own rules broke or other addons conflict

for replacing addon in download lib there is 2 files and folder files put in lib\LibButtonGlow-1.0 but folder put in lib\LibStub

SlivaNilow avatar Oct 28 '22 03:10 SlivaNilow

I suspect these changes are tainting other addons. The LUA errors were coming from them. Still though, it wasn’t working. No glowing buttons.

mario-64 avatar Oct 28 '22 03:10 mario-64

settings dont work, but glow work for me

there are something changed in AceConfigDialog:AddToBlizOptions for 10.0. so, maybe we can update the lib-ace3 to solve the problem.

shenjiayee avatar Oct 28 '22 06:10 shenjiayee

IT WORKS You just need to open the folder from here https://www.curseforge.com/wow/addons/libbuttonglow-1-0/download/4040423 and replace folder LibStub here _retail_\Interface\AddOns\AdiButtonAuras\LibStub and then 2 files "LibButtonGlow-1.0.lua" and "LibButtonGlow-1.0.lua" replace here _retail_\Interface\AddOns\AdiButtonAuras\LibButtonGlow-1.0

mateuszgrochowski avatar Oct 28 '22 08:10 mateuszgrochowski

So the temp fix works, I do not have errors enymore but AdiButtonAura gives me this warning nonetheless : image

asrandor avatar Oct 28 '22 11:10 asrandor

IT WORKS You just need to open the folder from here https://www.curseforge.com/wow/addons/libbuttonglow-1-0/download/4040423 and replace folder LibStub here retail\Interface\AddOns\AdiButtonAuras\LibStub and then 2 files "LibButtonGlow-1.0.lua" and "LibButtonGlow-1.0.lua" replace here retail\Interface\AddOns\AdiButtonAuras\LibButtonGlow-1.0

and you also need to fix AdiButtonAuras/SMBH/SMBH.lua - line 37,

local texturePath = "Interface\\AddOns\\AdiButtonAuras\\SMBH\\media"

just use a static path instead

besides, i got a tempfix for the settings.

  1. download the new ace3-config-lib to replace the lib files in the folder \AdiButtonAuras\libs\AceConfig-3.0- replace them by the same-name folder.
  2. in src file AdiButtonAuras/libs/AceConfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua - after line 2002, add code like this:
				Settings.RegisterAddOnCategory(subcategory)

it would be like this

				-- force the generated ID to be used for subcategories, as these can have very simple names like "Profiles"
				group:SetName(subcategory.ID, parent)
				Settings.RegisterAddOnCategory(subcategory)
			else
				local category = Settings.RegisterCanvasLayoutCategory(group.frame, categoryName)
  1. comment the code about face configuation panel in AdiButtonAuras/core/Core.lua line: 445-449
--local configLoaderPanel = CreateFrame("Frame")
--configLoaderPanel.name = addonName
--configLoaderPanel:Hide()
--configLoaderPanel:SetScript('OnShow', function() return addon:OpenConfiguration() end)
--InterfaceOptions_AddCategory(configLoaderPanel)

line: 462-472

	-- Remove the fake configuration panel
	--configLoaderPanel:SetScript('OnShow', nil)
	--configLoaderPanel:Hide()

	--print(INTERFACEOPTIONS_ADDONCATEGORIES)
	--for i, panel in ipairs(INTERFACEOPTIONS_ADDONCATEGORIES) do
	--	if panel == configLoaderPanel then
	--		tremove(INTERFACEOPTIONS_ADDONCATEGORIES, i)
	--		break
	--	end
	--end
  1. since function InterfaceOptionsFrame_OpenToCategory will be deprecated soon so replace all InterfaceOptionsFrame_OpenToCategory to Settings.OpenToCategory in src file AdiButtonAuras/core/Core.lua and AdiButtonAuras/config/Config.lua

but in this way at the first time to open the configuration panel, you should use slash cmd /aba or /adibuttonauras to generate the configuration panel, and then enter it from the settings.

it seems that blz wastes the global var INTERFACEOPTIONS_ADDONCATEGORIES, and does not provide a new way to remove a category from the addon-category-list yet.

shenjiayee avatar Oct 29 '22 03:10 shenjiayee

local texturePath = "Interface\\AddOns\\AdiButtonAuras\\SMBH\\media"

I have tested this and found out that textures could not loaded due to missing \\ at path end This fixed it:

local texturePath = "Interface\\AddOns\\AdiButtonAuras\\SMBH\\media\\"

Now I have the colored button borders back.

tholanis avatar Oct 29 '22 09:10 tholanis

Any chance you can upload your modded code / zip somewhere, please?

reed-kevin avatar Oct 29 '22 15:10 reed-kevin

I’ve made these exact changes and still it doesn’t work. No glow and taints to other addons 😞

mario-64 avatar Oct 29 '22 16:10 mario-64

Managed to get it working. Uploaded here

Share updated so people can download!

reed-kevin avatar Oct 29 '22 21:10 reed-kevin

Ok with so many fixes spread all over it might be hard to figure it out. But after 2 days of testing here goes.

From gelid original fix, what to do:

*** DO NOT DO THIS *** in file _retail_\Interface\AddOns\AdiButtonAuras\AdiButtonAuras.toc comment #SMBH\lib.xml *** DO NOT DO THIS ***

Step 1 ***

in file _retail_\Interface\AddOns\AdiButtonAuras\core\Core.lua

comment by adding -- at the start of the line like bellow

--hooksecurefunc('PetActionBar_Update', function() -- for i = 1, NUM_PET_ACTION_SLOTS do -- UpdateHandler('PetActionBar_Update', _G['PetActionButton'..i]) -- end --end) --hooksecurefunc('StanceBar_UpdateState', function() -- for i = 1, NUM_STANCE_SLOTS do -- UpdateHandler('StanceBar_UpdateState', _G['StanceButton'..i]) -- end --end)

Step 2 ***

Download https://www.curseforge.com/wow/addons/libbuttonglow-1-0/download/4040423 unzip copy files LibButtonGlow-1.0.lua and LibButtonGlow-1.0.toc into _retail_\Interface\AddOns\AdiButtonAuras\libs\LibButtonGlow-1.0 and replace existing files copy files LitStub\LibStub.lua and LitStub\LibStub.toc into _retail_\Interface\AddOns\AdiButtonAuras\libs\LibStub and replace existing files

From shenjiayee fix, what to do:

Step 3 ***

Edit AdiButtonAuras/SMBH/SMBH.lua - line 37,

local texturePath = "Interface\\AddOns\\AdiButtonAuras\\SMBH\\media\\"

this makes *** DO NOT DO THIS *** part not needed and also added the \\ at the end of the path like tholanis pointed out. Also i tried the setting fix and it broke everything so try at your own risk.

All merit goes to gelid, shenjiayee and tholanis; i just put it all together in one post.

Final note some glows dont work due to changes in talents and spells, it's not the addon or fixes fault, guess we will have to wait for updated libs for that.

persath avatar Oct 29 '22 21:10 persath

Ok which is it?

local texturePath = "Interface\AddOns\AdiButtonAuras\SMBH\media\" OR local texturePath = "Interface\AddOns\AdiButtonAuras\SMBH\media"

One slash or two?

mario-64 avatar Oct 29 '22 21:10 mario-64

Ok which is it?

local texturePath = "Interface\AddOns\AdiButtonAuras\SMBH\media" OR local texturePath = "Interface\AddOns\AdiButtonAuras\SMBH\media"

One slash or two?

two slashes in all, just updated the post sorry about that

local texturePath = "Interface\\AddOns\\AdiButtonAuras\\SMBH\\media\\"

persath avatar Oct 29 '22 21:10 persath

Thank you @persath ! Now it's working for me. What was breaking it evidently was the instruction to comment out #SMBH\lib.xml. As you mentioned that part is wrong.

mario-64 avatar Oct 29 '22 21:10 mario-64

Thank you @persath !!!! Auras are working now. I still get some errors when i log on or reload but so far so good xD

Zifijo avatar Oct 30 '22 00:10 Zifijo

@reed-kevin @persath @mario-64 I upload the fixed one to my space. https://github.com/shenjiayee/AdiButtonAuras/ I will try to fixed the problem until the original author updates.

shenjiayee avatar Oct 30 '22 07:10 shenjiayee

@shenjiayee thanks, but while the displayed URL is fine, I think the link is a bit broken ;)

Nulgar avatar Oct 30 '22 20:10 Nulgar

found alternative https://www.curseforge.com/wow/addons/litebuttonauras its work for me

SlivaNilow avatar Oct 31 '22 04:10 SlivaNilow

@shenjiayee thanks, but while the displayed URL is fine, I think the link is a bit broken ;)

@Nulgar fixed

shenjiayee avatar Oct 31 '22 13:10 shenjiayee

So, while solutions posted here made this addon work again in 10.0.0 it's now again giving errors in 10.0.2 :-( These are the errors I got upon logging in, haven't tested it yet in combat:

2x ...nterface/AddOns/AdiButtonAuras/core/DebugTooltip.lua:160: hooksecurefunc(): SetUnitAura is not a function [string "=[C]"]: in function `hooksecurefunc' [string "@Interface/AddOns/AdiButtonAuras/core/DebugTooltip.lua"]:160: in main chunk

Locals:

2x Interface/AddOns/AdiButtonAuras/core/DebugTooltip.lua:1 (null)

sthdevilish avatar Nov 16 '22 08:11 sthdevilish

Temp Fix - prevent the debug tooltip code from loading. In the file /core/core.xml remove the line that references DebugTooltip.lua

<Ui xmlns="http://www.blizzard.com/wow/ui/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.blizzard.com/wow/ui/ ..\FrameXML\UI.xsd"> <Script file="Utils.lua"/> <Script file="Core.lua"/> <Script file="SafeEnv.lua"/> <Script file="AuraTools.lua"/> <Script file="Description.lua"/> <Script file="RuleDSL.lua"/> <Script file="Items.lua"/> <Script file="Overlays.lua"/> <Script file="Display.lua"/> </Ui>

reed-kevin avatar Nov 16 '22 20:11 reed-kevin

I've tried the fix above, but it only produced more errors :-(

sthdevilish avatar Nov 18 '22 08:11 sthdevilish

Uploaded the file here: https://drive.google.com/file/d/18X_Lh7UVORK5tSs0Ij_-3Hgqj2qrQ2_x/view?usp=sharing

reed-kevin avatar Nov 18 '22 09:11 reed-kevin

Thanks reed-kevin! It works, I must have made a typo somewhere.

sthdevilish avatar Nov 18 '22 21:11 sthdevilish

This addon is dead. I wouldn't recommend any of you changes codes from people you don't know. They aren't working anyhow.

SharonS420 avatar Dec 09 '22 18:12 SharonS420

I agree. This addon is dead. I’ve switched to Lite Button Auras which is supported and working well for me.

mario-64 avatar Dec 09 '22 18:12 mario-64