AGH script on uninstall doesn't remove all of its files

[knaggsy2000]

Prerequisites

• [X] I have checked the Wiki and Discussions and found no answer

• [X] I have searched other issues and found no duplicates

• [X] I want to report a bug and not ask a question or ask for help

• [X] I have set up AdGuard Home correctly and configured clients to use it. (Use the Discussions for help with installing and configuring clients.)

Platform (OS and CPU architecture)

FreeBSD, ARM64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

Edge

Action

When testing different versions of AGH, I noticed upon uninstall and the install of the new version - that it errors out with: -

installation failed, removing /opt/AdGuardHome
cannot install AdGuardHome as a service

That's because the AGH script didn't remove the init.d script. So had to issue: -

# rm /usr/local/etc/rc.d/AdGuardHome

Then after last issue the install again and it goes fine.

Expected result

I expect the uninstall to remove any file it had installed previously

Actual result

Error mentioned above

Additional information and/or screenshots

No response

[knaggsy2000]

This further extends to how the "uninstall" script works, as it just wipes out the installation directory without ANY regard to the files/folders currently installed - that's NOT good practice, especially with BSD-based OS'es.

[knaggsy2000]

That's the thing with BSD-based OS'es - they ALL have strict directories for events (and more). But with every Linux OS - nope, it seems to be free-rain, there isn't a standard at all. This is one on the reasons I've settled on a BSD system.

[knaggsy2000]

@ainar-g @EugeneOne1 This issue isn't about the reference "symbolic links" issue mentioned earlier (please remove that). Just a simple issue with the script used for uninstalling.

[knaggsy2000]

@ainar-g @EugeneOne1 And update on this issue?

[knaggsy2000]

@ainar-g Any update on this issue?

[EugeneOne1]

@knaggsy2000, hello and apologies for the late reply. Do you still experience this? Unfortunately we can't reproduce the issue, the service file is successfully removed on our machines.

Could you please collect a verbose log recorded while performing the "uninstall" action? You may send it to our [email protected].

[EugeneOne1]

@knaggsy2000, we're going to close this issue for now. Please reopen it with the logs if it's not resolved.

[knaggsy2000]

@EugeneOne1 I would need to re-test this when I can, but yes - close the issue until further notice.