Missing Features in BetterViewer v2
I have never used React or Typescript, so I'm a bit out of my depth as far as submitting a pull request goes, but these are the features I can see that are not currently in v2:
User Customization: unless I'm missing something, there is no more 'Settings' button
-
chrome.storage.syncis still available in MV3, although I'm not sure if you're just trying to avoid any sort of local storage saving/loading for the sake of simplicity. - You could optionally put 'settings' in the standard "options_page", so you don't have to worry too much about styling or creating a physical element in the extension window. This will allow people who care about customization to still be able to do so, but should be quite a bit easier for you to create.
- Zoom ratio (allows the user to increase/decrease the rate at which an image zooms)
- this seems to use percentage scaling, not integer scaling (although it was the same in v1, just thought I'd mention it)
- Customizable hotkeys
- this was never actually enabled in v1.0.5 but it was available in the old code base, with manual installs
- and if you don't hard code everything like an idiot (me, circa 2022), this can be done in ~20 lines of code
Theme: Solid Color vs Blurry background
- in v1 this was only dark/light/blurry, but there is no reason it shouldn't use something like hex/rgb
- having it default to 'blurry' may look better (subjectively), but it makes many images harder to actually see
Fit to Screen: maximizes based on the image's largest dimension
- this was never actually enabled in v1.0.5 but it was available in the old code base, with manual installs
- if horizontal is closer to the sides, then it zooms to the maximum horizontal allowance
- if vertical is closer to the top/bottom, then it zooms to the maximum vertical allowance
- the code from the old version was very simple, so it shouldn't be hard to implement something similar.
Hello @Metacor, long time no see!
Really appreciate you taking the time to lay all this out.
User Customization: unless I'm missing something, there is no more 'Settings' button
Yeah, you’re right... customization took a bit of a hit in v2. I haven’t brought back the settings menu yet, mostly to keep things simple, but using "options_page" sounds like a great way to reintroduce it without overcomplicating the UI. Definitely working on it. 👍
chrome.storage.syncis still available in MV3, although I'm not sure if you're just trying to avoid any sort of local storage saving/loading for the sake of simplicity.
Working on it.
- You could optionally put 'settings' in the standard "options_page", so you don't have to worry too much about styling or creating a physical element in the extension window. This will allow people who care about customization to still be able to do so, but should be quite a bit easier for you to create.
Working on it.
Zoom ratio (allows the user to increase/decrease the rate at which an image zooms)
- this seems to use percentage scaling, not integer scaling (although it was the same in v1, just thought I'd mention it)
Got it! I’ll add it soon.
Customizable hotkeys
- this was never actually enabled in v1.0.5 but it was available in the old code base, with manual installs
- and if you don't hard code everything like an idiot (me, circa 2022), this can be done in ~20 lines of code
Haha 😆, I feel that! Customizable hotkeys are definitely a must-have, and I’ll be adding them very soon.
Theme: Solid Color vs Blurry background
- in v1 this was only dark/light/blurry, but there is no reason it shouldn't use something like hex/rgb
- having it default to 'blurry' may look better (subjectively), but it makes many images harder to actually see
I’ll make this customizable in the options page.
Fit to Screen: maximizes based on the image's largest dimension
- this was never actually enabled in v1.0.5 but it was available in the old code base, with manual installs
- if horizontal is closer to the sides, then it zooms to the maximum horizontal allowance
- if vertical is closer to the top/bottom, then it zooms to the maximum vertical allowance
- the code from the old version was very simple, so it shouldn't be hard to implement something similar.
I'll take a look at this and see how best to integrate it.
To sum up:
This update is mainly a response to Google's Manifest V3 changes. The missing features will be added soon. Thanks again for your feedback ❤ I really appreciate it!
I've implemented the "Open Image in New Tab" option in the latest update v2.0.2 🎉 Now you can easily open images in a new tab while still using BetterViewer.
https://github.com/user-attachments/assets/51652dae-9187-4969-98fb-0dfc9bf3edad