Minigames icon indicating copy to clipboard operation
Minigames copied to clipboard

Include armour slots

Open MiniWorks18 opened this issue 5 years ago • 4 comments

Currently, items are only taken from the player's inventory, this should allow items to be taken from their armour slots as well.

Purpose

Describe the problem or feature in addition to a link to the issues.

Approach

How does this change address the problem?

Open Questions and Pre-Merge TODOs

  • [ ] Use github checklists. When solved, check the box and explain the answer.

Learning

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Blog Posts

MiniWorks18 avatar Apr 19 '20 05:04 MiniWorks18

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- Regions/src/main/java/au/com/mineauz/minigamesregions/actions/TakeItemAction.java  2
         

See the complete overview on Codacy

Narimm avatar Jun 03 '20 05:06 Narimm

Also you cant concat those item arrays like that...it wont meet the slot requirement

Narimm avatar Jun 03 '20 10:06 Narimm

Bluntly put this wont work as currently handled.

Narimm avatar Jun 03 '20 10:06 Narimm

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 21 '20 10:06 CLAassistant

Closing - PR is very old and doesn't seem to have been tested, or provide the functionality in a suitable way.

addstar avatar Jun 20 '23 04:06 addstar