AmadeusGPT icon indicating copy to clipboard operation
AmadeusGPT copied to clipboard

import * [WIP]

Open MMathisLab opened this issue 2 years ago • 2 comments

  • suggestion to import all classes vs. import *

MMathisLab avatar Dec 16 '23 19:12 MMathisLab

I know your point. I can make a PR to fix it. amadeusgpt/modules are meant for integration modules and I thought using import *, the potential contributors do not have to bother to edit init.py. But maybe it's a bad practice and I can fix. But note amadeusgpt/modules/implementation/ is different from amadeusgpt/implementation (where core module implementation is)

yeshaokai avatar Dec 16 '23 19:12 yeshaokai

great; feel free to edit this branch as you like! No rush.

MMathisLab avatar Dec 16 '23 19:12 MMathisLab