duality icon indicating copy to clipboard operation
duality copied to clipboard

The Output folder now contains a lot of files that don't belong to Duality

Open ilexp opened this issue 5 years ago • 6 comments

Summary

I'm not sure what happened, or when exactly it happened, but my build output folder now looks like this:

explorer_p7Dev4Kbsf

There is a ton of files and folders that have nothing to do with Duality or the editor, which is confusing at best and could somehow end up in some packaged binary in the worst case. Can we get back to the old state?

Analysis

  • Could this have something to do with the recent addition of DualityBenchmarks?

ilexp avatar Jul 17 '20 07:07 ilexp

@Barsonax Assigning you, because you probably have the best idea of any of us how this might have happened, or how to address it.

ilexp avatar Jul 17 '20 07:07 ilexp

This is the output of the benchmarks. They need to end up in the same folder so that everything is available else things don't work correctly.

It would indeed be cleaner if the output ends in its own folder but we have to make sure it can still load all the required dlls.

Rick-van-Dam avatar Jul 17 '20 07:07 Rick-van-Dam

Same happens atm with the unit tests btw

Rick-van-Dam avatar Jul 17 '20 09:07 Rick-van-Dam

This is not really a blocked I think for v4.0. Its not pretty but everything does work (and it only affects developers of duality, not users) as it should so I think we should remove it from the 4.0 milestone so its not blocking for the release @ilexp

Rick-van-Dam avatar Jul 23 '20 12:07 Rick-van-Dam

Agreed, moved it out of the milestone.

ilexp avatar Jul 23 '20 19:07 ilexp

Moving this into 4.0 again, since we're currently in a somewhat slow / stale mode, making it more important to have a clean dev environment, both for picking up again later and providing a better place for new contributors to start.

ilexp avatar Dec 28 '20 09:12 ilexp