krita-ai-diffusion icon indicating copy to clipboard operation
krita-ai-diffusion copied to clipboard

Upscale issue #8: the rendered layer’s title doesn’t reflect the upscale job performed

Open minsky91 opened this issue 1 year ago • 2 comments

No matter what kind of upscale job has been performed, the resulting layer’s title always looks like this:

[Upscale] 1536x2048 (1786158082)

This makes it difficult to distinguish between the various upscale/refine versions created in the layer stack. The layer title should reflect at least: the upscaler model, the refiner style used, the Strength and the (beginning part of the) prompt used (or none) - similarly to the way it’s implemented in the Generate/Refine part of the plugin.

minsky91 avatar Oct 18 '24 14:10 minsky91

I don't really like to put that much stuff into the layer name. Generate/refine also only use abbriviated prompt + seed. Resolution feels like the most important thing about an upscale?

Acly avatar Nov 12 '24 22:11 Acly

Well, the plugin already appends a hefty cryptical substring to the layer name upon upscale, e.g. (2075337012) - do we really need that? Instead, at least a substring indicating whether a refine operation was applied could be added, like "refine 30% unblur med", or something. Will serve as a useful reminder for dealing with this layer later on among others in the stack, to indicate that no further refine needed. (Believe me, it's easy to forget when doing numerous upscales and optional refinements one after another.)

No need to add the prompt text in this case, agreed.

minsky91 avatar Nov 12 '24 23:11 minsky91