cnvrg-operator icon indicating copy to clipboard operation
cnvrg-operator copied to clipboard

DEV-15206-ingress added tls capabilities

Open nctiggy opened this issue 3 years ago • 0 comments

This is a fairly large PR and may be suited to a code review together so we can talk through all the changes.

We tested all variations of the two new spec items and the ingress's that go with it.

Two ingresses (router/minio) were pointing to incorrect ports (the services were hard set to port 80). I just changed the ingress side to be correct as I was unsure if there was a reason we were hard setting svc's to 80.

This also remedies an issue where annotations and labels with bool in their value do not parse correctly, This change was to the helm template file for the labels and annotations.

Also included were some formatting nuance

acmeCert - This will allow a customer that is leveraging acme style certs with their internal cert authority to have unique secrets generated by a tool such as certManger

className - For customers that do not have a default ingress class set or want us to use a non default class, this spec item allows users to specify the class they would like

if https is set to true, we will now also be adding the tls section to the ingress, if you pass a wildcard cert secret name we will populate the secret for each ingress with that name.

In the core ruby app, ingress is still broken and needs to be resolved to match these changes in order to ensure full compatibility.

nctiggy avatar Aug 10 '22 19:08 nctiggy