openvdb icon indicating copy to clipboard operation
openvdb copied to clipboard

Replace boost conversion_traits with std::common_type

Open Idclip opened this issue 2 years ago • 4 comments

Re-creating this so that we don't lose visibility on it. It currently cannot be merged due to https://github.com/AcademySoftwareFoundation/openvdb/issues/1700

Idclip avatar Dec 06 '23 03:12 Idclip

One possible option given that std::numeric_limits is overridden is to try using std::numeric_limits<T>::is_specialized instead. https://en.cppreference.com/w/cpp/types/numeric_limits/is_specialized

bpmckinnon avatar Dec 20 '23 21:12 bpmckinnon

I've verified that this is at least a potential option on my windows build... but I can't guarantee it will work in the build environment that is failing.

bpmckinnon avatar Dec 20 '23 22:12 bpmckinnon

As for the problem that Matthew raised in Issue 1700 , I have a fix that I included in the draft PR for supporting half grid. What's needed is adding a cwiseAdd specialization for Vec3<math::half> as shown here.

apradhana avatar Dec 20 '23 22:12 apradhana

Has there been any update on the cwiseAdd function? Otherwise I can add the is_specialized change I proposed.

bpmckinnon avatar Apr 30 '24 14:04 bpmckinnon