openvdb icon indicating copy to clipboard operation
openvdb copied to clipboard

Use angle brackets for non-relative paths

Open gaida-exe opened this issue 3 years ago • 1 comments

Since Ken mentioned that he wants angle brackets, I also created an angle bracket PR and this would be the counterpart to https://github.com/AcademySoftwareFoundation/openvdb/pull/1363.

It shortens the relative paths that could be shortened and unifies all not relative paths to use angle brackets.

gaida-exe avatar Jun 15 '22 08:06 gaida-exe

Sorry for the ping, but would be great, if you could run the CI and maybe take a look. (you took a look at the previous PR https://github.com/AcademySoftwareFoundation/openvdb/pull/1363) @jmlait @Idclip @danrbailey

gaida-exe avatar Sep 20 '22 18:09 gaida-exe

I've just pulled master without conflicts, because the CI failed. Maybe this can fix the issues. On Windows TBB was missing. (failed Action)

gaida-exe avatar Oct 12 '22 06:10 gaida-exe

can you try this in your fork:

git fetch upstream
git merge upstream/master
git push origin angle-brackets

assuming you previously did

git remote add upstream [email protected]:AcademySoftwareFoundation/openvdb.git

kmuseth avatar Oct 12 '22 19:10 kmuseth

Thanks for the suggestion Ken, but the branch is already merged with the latest commit of the upstream OpenVDB version (0efd583) And as said, only the non-related NanoVDB build is failing, because of CUDA. I don't know if it would change anything, but maybe rerunning the CI without a change could work, if something blocked the install.

gaida-exe avatar Oct 12 '22 20:10 gaida-exe