OpenTimelineIO icon indicating copy to clipboard operation
OpenTimelineIO copied to clipboard

Kdenlive: fix transition convertion failure

Open vpinon opened this issue 5 years ago • 6 comments

Link the Issue(s) this Pull Request is related to.

Each PR should link at least one issue, in the form:

Fixes #797

Summarize your change.

kdenlive adapter has a preparation for transitions support (dissolve as a start). but this partial support was not enough tested and fails on some conditions ("in" property in MLT XML missing when it is 0). This leads otioconvert to fail.

This change just adds a default 0 value when no MLT "in" property is found.

Reference associated tests.

The situation is added in the test sample. Unfortunately the dissolve re-import is not yet implemented, so the export/import loop test must be disabled for now.

vpinon avatar Sep 14 '20 20:09 vpinon

What is the progress here @vpinon ?

jlskuz avatar Feb 02 '21 13:02 jlskuz

Sorry I haven't spent any time on this. It's still on my todo list...

vpinon avatar Feb 02 '21 14:02 vpinon

Okay, nice!

jlskuz avatar Feb 02 '21 14:02 jlskuz

@vpinon Is this issue still open, or has it been resolved by your other work on the kdenlive adaptor?

meshula avatar Feb 23 '22 00:02 meshula

1 year later, still open. Since then, Kdenlive format has evolved and it is not the only issue :(

vpinon avatar Feb 24 '22 21:02 vpinon

It's evolved, and there's new issues? That's unfortunate :(

meshula avatar Feb 25 '22 00:02 meshula

This can be closed now since the Kdenliven adapter moved #1438

jlskuz avatar Jan 22 '23 10:01 jlskuz