OpenRV icon indicating copy to clipboard operation
OpenRV copied to clipboard

[ 423: Non RHEL building ]

Open lithorus opened this issue 1 year ago • 1 comments

Fixes #423

Summarize your change.

Have removed the blocking of trying to build on non-RHEL distro and changed to only use lib64 on RHEL distros.

Describe the reason for the change.

Unable to build on eg. Ubuntu

Describe what you have tested and on which operating system.

Have tested with Ubuntu 20.04 using a custom build of Qt5 (and rest is standard repo packages)

Add a list of changes, and note any that might need special attention during the review.

Have not (yet) tested on a RHEL distro, but have made changes that differentiate between RHEL and non-RHEL Linux distros

lithorus avatar Mar 26 '24 20:03 lithorus

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: lithorus / name: Jimmy Christensen (ad8e7f3f5d4534f39de21550a396e07ab22bd8aa, 15dc9e434d38a17f41fbce77f3238710dfad3061, 4372f51ac91531e82e656b2930b28a97a58be047, b03274f9628ce1a1bd49d7cc9f1845f576fed7a5, 2bc9fc23e0c000b0d9c41c276feef9909857be6a, 51559848192a4ef72c633c0b4f066f167d3fab29)
  • :white_check_mark: login: bernie-laberge / name: Bernard Laberge (28ad85ff737c2d76e81d6409c6d461335c285a59)

Thank you for checking in internal CI I should mention that I noticed that #461 PR breaks the non-RHEL build (but easy to fix). If it gets pulled again, I'll just create a new PR.

lithorus avatar May 29 '24 08:05 lithorus