OpenCue Cuebot reserve all cores

Link the Issue(s) this Pull Request is related to. Fixes #1297

Summarize your change. As in many render engines, we should be able to set a negative core requirement. minCores=8 > reserve 8 cores minCores=0 > reserve all cores minCores=-2 > reserve all cores minus 2

This PR addresses this feature by handling negative core requests. Cuebot will try to match this number against the number of cores on each host. The frame will be booked only if all cores are available in this scenario. If the host is busy (even slightly), the frame is not booked, to avoid filling the remaining cores.

Testing I would need some guidance to create proper tests for cuebot.

Screenshot negative_cores

Aug 26 '23 01:08 KernAttila

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: KernAttila / name: Kern Attila GERMAIN (33c295232807f67ab27629a5b5f6f39f417f7bbd, 48758fb4da1f6516b4216e7054ee49188a8e23c6, 902d30ae79d5ab44d6f864e0d140c00aca6194d4, 00f911185cf390ef44eebe781bb4f232ea27d5ba, b442fe7911e2558fed1b85f0775530cd1bc9546c, 7e8c48ed48c5db0214174fb1b8055b3dadf23eeb, 9baba0bedbd65cb408958437c9a13bcf56476124, e5a77fe7fe51b22f63326ca9da4bc0616080d100, ca89e05983af95c55ec378ff5d9c26b91addc461, 5c9dcf4cb9c1aac9a8913c3987d9820d7d0a2729, 939bfe6f808d37147f13d8037623f0731aef5692, 7c3f61c2b70ae2e8c6322debd999821b154c3b8e, da57b2e8af40da140ca3578962ff1b01ad21eb14, 3a793b7ac90f4c66be09d590bb6cda49e9617b75, fd1720672f0ad7ea4c48e11d060d5bea66e4b1f9, 8f802404b2df5d29feec1cb5609886cf3b47cb3b, c3d2c24106223da225f8c789185b35793d36ddbd, 19521d96b42c8f1606a48e2e50de9f5e0baedae2, 78fb71de36e34a6b477697bcd120cc6dbc3dce66, f82485ea52599523792c3bd6f70bd162f7da3c2b, 7ca29186ebc913290370efd9129a2933e8902119, 263b2485366511971adb33208fee1e0483a743f4, 2cd6945c3f111cc9eb60480eebe5fa5f35284fe7, 7e10f646ec9393dae614d03040920188b0088c83, 3b94240ea412fb756381702fbef63ad2338eba1c, fd4a040fc779e50e00afb44747127e2f94d3de3f, ef2b6277b5d7bfb734d1805711b42bc9f4e0e0b2, 7a3917de6c31472277f127ad1da2f783282ba5ec, 7309701212ee3d7c5b85447b4e7d8d9e72153893, a392a3dabf93f17931cd69db047e0cfa95383666, 145d14e8d3cd16e1d8f9a0312b1c8e55b0f46297, 1c79a55d539454b1f7fb44231fa5f77613cedb49, 1dfd79b18cdbfe2d53a2e6e2c22b7faa02dece2a, adf59096d3e2b9ba871bf44542d7bba84ec61cf6, 7f3e24c3a090ccf94ac3ed247821c6d68c847237, 1f24058e067543ddfe530072187cad55765f2183, 2067abf9ad405a7d05a5bf84c2740b320dba0f2a, 8a0f001a36b567c4a0041754f52548170424d5db, cc4744b8f708f6140b0c4326ffe8a6c87844a01f, 866d738eb93800ec7718df3c830aef518c179115, 627274a45253231ab16ed24642c529d64da7797f, 06b7f8cd61b136f9cacc68cbce9c42725453ceff, 2081bf4e8f25fddfe151467513cd5ce5b30a0b25, 21794dc184ac29fa8d69234b37ea806429bf4c3c, 29282bdec99017dc70353d97bde40b05477d2de4, 85bab384cf3df0a453357d3572bfed5e406cd67a, 8ff11e36987cc96aba75ea6e916d37f82fa4c1a0, 2634735dacbd38ac00acbb75042c17e49148eac4, c4fc5537df47d577541fce4a706a6db355f88321, de62e36b3ea116e53882af223a4356475bd34f2a, 1f0d7d9ffc2708a0aafb8db3aa6d6ba0171c2f82, a97b4c0c5a17517333beaf9f50503df8b0427b3b, 9b57fe988618a19cc838d936e887b4935663abd0, 247327eb4c879d3d1b6c4cb35eea09f939cfcbf3, 1a93ca19753a2f9f1caee0e983ce98879af42c72, de80d1d59e8b314411a4e8375bbcd8b84de4698a, 444253076c6d3339eaec6cc2b8e6189c02244d31, 00e29993d0dfe8aeaa2f6816058d2c501011e1c8, f93754b7b4ef7bedd1366dbf747cc1df9e8dee51, 962ce55ab17243c5cb4ad936cce6d4e13c123fa7, dd44a7aeb0fb3dd2520b92653540966a75b0d5ff, cc0f3a969c7677bdf60dcef6e2462986175b7090, d64039bd085c885c72344a8062264f50c872b1f9, 9eddb03c04f230280071c2b77ae665e9f3e7332a, 06195b77b3a4778e8d4ddd6ab263e0b7697f82f8, a2aa63130ac626cd4b90faa84f7365c3052129b0, 748b12d63545f7b270e23885aefe9789858e47ae, 014b91b9b0aaf4f2c603e73cf62c7fb84ee548d4, b96dbe14371cb44a036905597fe20ac95da4f582, 4efe60192b9f3c3b3411bc8d5b20b363e120da0f, 191bdca50ccd057fb76317e94474ccbacc6a1fa2, e7022cc2f5eed3bbe3ca0bade536cecd15bd6b84, f17d7ae2ecf9d75632a993798ba865ed061a757b, 302a67ff6d843715969bce6532d85fce46f86a07, 5ff094a798f28a300c98dc8be60ebf79d07f1d7d, 79b6d1159ad7d01feacaf44f399095075e722f6b, 2ccd2e4d536614bf3e8bb4e2593f2bc5feaf64f8, 359ed535e88176b87fd555d77a775bf4ceabcb5b)

Aug 26 '23 01:08 linux-foundation-easycla[bot]

Very interesting addition, thanks for sending this!

I haven't dug into this much yet but I brought it up during the TSC meeting, we're going to discuss some more.

One thing to note -- we'll definitely want to wrap this in a flag so it can be turned on and off. Scheduling changes are always tricky and we don't want to disrupt other folks too much.

Sep 27 '23 21:09 bcipriano

@DiegoTavares Let me know if y'all have thoughts on this.

Sep 27 '23 21:09 bcipriano

@bcipriano Would you recommand it to be on or off by default ?

Nov 09 '23 09:11 KernAttila

IMO we should default to keeping this feature disabled. Very well implemented and an interesting feature to have.

Would you mind writing a blog post explaining the concept and how to use it?

Thanks for the review.

I don't have access to a Linux farm at the moment, but we are doing a Windows set-up very soon. I'll need a bit more time for this one, and I will try to have that blog post ;)

May 21 '24 17:05 KernAttila

Thanks Kern

Diego Tavares da Silva @.*** @.***

On Tue, May 21, 2024 at 10:32 AM Kern Attila GERMAIN < @.***> wrote:

IMO we should default to keeping this feature disabled. Very well implemented and an interesting feature to have.

Would you mind writing a blog post explaining the concept and how to use it?

Thanks for the review.

I don't have access to a Linux farm at the moment, but we are doing a Windows set-up very soon. I'll need a bit more time for this one, and I will try to have that blog post ;)

— Reply to this email directly, view it on GitHub https://github.com/AcademySoftwareFoundation/OpenCue/pull/1313#issuecomment-2123111053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQ22BGDF3GFM45ZK7CT3ZDOAJ3AVCNFSM6AAAAAA37FUL5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGEYTCMBVGM . You are receiving this because you were mentioned.Message ID: @.***>

May 21 '24 17:05 DiegoTavares