AcademySoftwareFoundation
Cuesubmit browse widget
Link the Issue(s) this Pull Request is related to. https://github.com/AcademySoftwareFoundation/OpenCue/issues/1279 https://github.com/AcademySoftwareFoundation/OpenCue/issues/1271
Summarize your change.
This PR adds an optional Browse button to CueLabelLineEdit
You can enable it with setFolderBrowsable() or setFileBrowsable()
This function accepts optional file filters.
Applied those features to Maya, Nuke and Blender widgets (Do we need additional file filters for those ?)
Screenshots.
File browser with filters:
Folder Browser:
This branch unfortunately got caught in conflicts. @KernAttila would you be willing to fix the conflicts and push another commit. I'll review and merge right away
Have merged #1281 #1282 #1283 #1284 into this branch (and fixed conflicts and a few missing bugs) :
https://github.com/lithorus/OpenCue/tree/pr/1281
Should I just create a new PR for the collected PR's?
Have merged #1281 #1282 #1283 #1284 into this branch (and fixed conflicts and a few missing bugs) :
https://github.com/lithorus/OpenCue/tree/pr/1281
Should I just create a new PR for the collected PR's?
No problem, @lithorus. Thanks!
Once your new PR is merged into the master branch, please make sure to comment on each of @KernAttila's PRs (https://github.com/AcademySoftwareFoundation/OpenCue/pull/1281, https://github.com/AcademySoftwareFoundation/OpenCue/pull/1282, https://github.com/AcademySoftwareFoundation/OpenCue/pull/1283, https://github.com/AcademySoftwareFoundation/OpenCue/pull/1284) to inform @KernAttila that the conflicts have been resolved. Include the link to your new PR in each comment. This will ensure @KernAttila is aware, and we can then cancel his PRs.
@KernAttila, please note that your contributions to the OpenCue project will be credited to your GitHub account since @lithorus has merged your code into his new branch.
@lithorus thanks for doing this, I couldn't find time to get back to those PRs recently. I'm glad it finally made it to the main branch :) I'll close those PRs. Except #1284 that was not included. It is ready now that the 3 previous ones where merged. Out of curiosity, have you had a chance to use the config file from this PR ? @ramonfigueiredo thanks for the info, glad to be part of the contributor list ;)
@lithorus thanks for doing this, I couldn't find time to get back to those PRs recently. I'm glad it finally made it to the main branch :) I'll close those PRs. Except #1284 that was not included. It is ready now that the 3 previous ones where merged. Out of curiosity, have you had a chance to use the config file from this PR ? @ramonfigueiredo thanks for the info, glad to be part of the contributor list ;)
Hmm.. I was fairly sure that it was included. I remember doing some of the tests mentioned in the PR. Will have to double-check. Edit: You're right, I didn't include it. Do you want me to create a new PR and merge in there?
No problem, well it seems to fail on CLA only, I'll check my history and amend the bad commits. Let's keep in touch about that, I'll try to have it done for next week. If I can't, we'll check for making a new PR :)
No problem, well it seems to fail on CLA only, I'll check my history and amend the bad commits. Let's keep in touch about that, I'll try to have it done for next week. If I can't, we'll check for making a new PR :)
Thanks @lithorus and @KernAttila !