MaterialX icon indicating copy to clipboard operation
MaterialX copied to clipboard

Fixes for the 3-way comparison in tests_to_html.py

Open krohmerNV opened this issue 2 years ago • 2 comments

Tried to do a comparison between MDL 1.6, 1.7, and 1.8 and found two issues:

  • the computed file paths are not correct when passing different --inputdir1, --inputdir2, and --inputdir3
  • when comparing basically mdl against mdl and mdl, the file names of the diff images collide

krohmerNV avatar Jul 18 '23 09:07 krohmerNV

@krohmerNV I like the idea of this improvement, though in my local tests it seems to break the simpler two-way comparisons between GLSL and OSL:

TwoWayComparison

jstone-lucasfilm avatar Nov 01 '23 14:11 jstone-lucasfilm

I'll investigate, thanks!

krohmerNV avatar Nov 02 '23 08:11 krohmerNV

@krohmerNV Just bumping this thread, in case you have a chance to follow up on this proposal!

jstone-lucasfilm avatar Aug 01 '24 20:08 jstone-lucasfilm

thanks @jstone-lucasfilm, I need to make time for this in the next week

krohmerNV avatar Aug 02 '24 09:08 krohmerNV

@jstone-lucasfilm updated the default parameters of the script to behave like before. Sorry it took so long.

krohmerNV avatar Aug 16 '24 11:08 krohmerNV