stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard
Published 4 months ago • verified publisher icon AUTOMATIC1111

restore the progress from session lost / tab reload

Open siutin opened this issue 3 years ago • 5 comments

Describe what this pull request is trying to achieve.

This PR attempts to restore the progress bar from session lost / tab reload

Environment this was tested in

  • OS: Ubuntu 22.04
  • Browser: Firefox 109.0.1 (64bit)

Screenshots or videos of your changes

https://user-images.githubusercontent.com/772892/216965025-0b6b284d-1ef9-460a-93b3-b34a09887fc5.mp4

siutin avatar Feb 06 '23 11:02 siutin

@siutin could you please resolve the conflicts so auto will be, in theory, able to review it?

hithereai avatar Mar 26 '23 20:03 hithereai

my problems with it:

  1. this allows you to "restore" other users' generations.
  2. considering (1), preventing img2img showing up in text2img seems not to be really necessary, and I don't want to add stuff to task ids just for that
  3. it's a fairly uncommon thing to do for user and it takes half the space away from the most useful button in the whole program

AUTOMATIC1111 avatar Mar 27 '23 03:03 AUTOMATIC1111

  1. That would require multiple user support. I'm not quite familiar with it, but I could have a look.
  2. This PR can restore progress for both txt2img and img2img. Therefore I'm not quite sure I understand this, maybe I'm missing something here?
  3. I can try making the button smaller or explore other options. Do you have any preferences on this?

my problems with it:

  1. this allows you to "restore" other users' generations.
  2. considering (1), preventing img2img showing up in text2img seems not to be really necessary, and I don't want to add stuff to task ids just for that
  3. it's a fairly uncommon thing to do for user and it takes half the space away from the most useful button in the whole program

siutin avatar Mar 27 '23 07:03 siutin

1 - how about saving task id locally in the browser (js localstorage) and using that to restore the session

2 - I'd like to not add any changes to task ids for simplicity and if the side effect of that is that you can load img2img results in text2img tab, that's not a problem

3 - well, how about a button below generate along with other buttons in that row.

As an extra together with (1) the button can be made only visible if the task id is stored locally and not visible otherwise, and local task id would be emptied after a generation finishes so the button would normally be hidden. this is getting fairly complex considering user can have multiple tabs open so maybe this extra can be dumped...

AUTOMATIC1111 avatar Mar 27 '23 07:03 AUTOMATIC1111

  1. It seems like back-end support would be a more appropriate way on this ...
  2. Okay
  3. No problem

siutin avatar Mar 27 '23 08:03 siutin

I've made some changes based on the feedback I received. For (1), I updated the Task API to be user-specific when authentication is enabled. This means that users won't be able to restore someone else's work unless they have the exact task ID. I hope this addresses the concern.

newui

siutin avatar Apr 24 '23 04:04 siutin

I ended up doing an independent implementation that tracks task id in browser locally and uses that to restore, showing the button only if the task id exists for a task that wasn't finished properly in the client.

AUTOMATIC1111 avatar Apr 29 '23 19:04 AUTOMATIC1111