devlib icon indicating copy to clipboard operation
devlib copied to clipboard

add type annotations and docstrings to devlib

Open arjpur01 opened this issue 11 months ago • 3 comments

Most of the files are covered, but some of the instruments and unused platforms are not augmented Minimum Python version required change from 3.7 to 3.10 in order to support some of the annotation features

arjpur01 avatar Feb 25 '25 16:02 arjpur01

Hi,

If this requires changing the minimum supported Python version that means we need to perform a new release of both devlib and the WA project on github and PyPI before we can merge this PR.

We should also check with our known users what version of Python they are currently using to ensure we provide sufficient time for any users to migrate if required before dropping support for < 3.10.

marcbonnici avatar Feb 25 '25 17:02 marcbonnici

Hi,

If this requires changing the minimum supported Python version that means we need to perform a new release of both devlib and the WA project on github and PyPI before we can merge this PR.

We should also check with our known users what version of Python they are currently using to ensure we provide sufficient time for any users to migrate if required before dropping support for < 3.10.

Hi Marc,

My changes dont exactly need the 3.10 version. I have modified now, to avoid the explicit dependency on the newer language features, for ex - changing imports of Literal, Protocol and TypedDict from typing_extensions instead of from typing. I have reverted the setup.py change to move up to 3.10 in this PR. I have validated on bench to use 3.7, 3.8, 3.9 and 3.10 python versions with this changes.

Still i think it is something we should pursue and move up to 3.10 in near future, but that effort can be taken up independent of this PR.

Kindly review my changes and do the needful.

Thanks and Regards, Arjun

arjpur01 avatar Feb 26 '25 13:02 arjpur01

Thanks Marc, I will look into the above and make the changes. meanwhile, please continue to review the code.

arjpur01 avatar Mar 24 '25 11:03 arjpur01