CMSIS_5 icon indicating copy to clipboard operation
CMSIS_5 copied to clipboard

adding "extern C" guard

Open CheMax-Tag opened this issue 4 years ago • 9 comments

I add missing "extern C" guard for some header files.

This can help to stub out the error described in #617 when using the C++ compiler.

I plan to check all the headers and add missing guards if you don't mind.

CheMax-Tag avatar Mar 11 '21 06:03 CheMax-Tag

Thanks @CheMax-Tag, may I ask you to update all file versions and dates of files you've touched, please? I consider this change (it is non-functional) as a patch level one, hence the file versions should be incremented in the third diget.

Cheers, Jonatan

JonatanAntoni avatar Mar 11 '21 08:03 JonatanAntoni

Ok. I'm sorry, this is essentially the first request in my practice).

Another question, the date indicated in the copyright should also be updated? I mean the year, for example, in this lines:

// Copyright (c) 2017-2020 IAR Systems //Copyright (c) 2017-2019 Arm Limited. All rights reserved.

should I change the year to 2021?

CheMax-Tag avatar Mar 11 '21 08:03 CheMax-Tag

Yes, please change the year to 2021.

ghost avatar Mar 11 '21 08:03 ghost

Ok, it's ready.

CheMax-Tag avatar Mar 11 '21 10:03 CheMax-Tag

Thanks for taking this over and contributing. May I ask you to sqash all your commits into a single one, please?

JonatanAntoni avatar Mar 11 '21 12:03 JonatanAntoni

Thanks for taking this over and contributing. May I ask you to sqash all your commits into a single one, please?

Yes, it will take me a while

CheMax-Tag avatar Mar 11 '21 13:03 CheMax-Tag

I'm a little confused with branches collapsing commits. Please understand, forgive.

Correct commit with all changes 38236c1

CheMax-Tag avatar Mar 11 '21 13:03 CheMax-Tag

Hi @CheMax-Tag,

no worries. The PR cannot be merged this way. It looks like you introduced a merge commit. You need to rebase (!) your changes onto the latest develop branch. During rebase you can squash all commits into a single one.

Cheers, Jonatan

JonatanAntoni avatar Mar 15 '21 11:03 JonatanAntoni

Can one of the admins verify this patch?

JonatanAntoni avatar Apr 28 '21 11:04 JonatanAntoni