soapy icon indicating copy to clipboard operation
soapy copied to clipboard
verified publisher icon AOtools

LGS elongation

Open GillesOrban opened this issue 5 years ago • 1 comments

Hi,

LGS elongation does not work when using ShackHartmann and one have to use ShackHartmannLegacy to be able to used it. This is because lineofsight.py and lineofsight_legacy.py diverge significantly. Not sure what is the idea, what was the motivation to have legacy files, and how much the legacy versions might be outdated. Modifying base.py and lineofsight.py to make the LGS elongation works do not seem trivial to me. What is your advice or plan here? Thanks

GillesOrban avatar Apr 01 '20 16:04 GillesOrban

From discussion wiht @ojdf - In the new concept, a new "LineOfSIght" object would be required for each "elongation point" along the LGS beacon. Hopefully this works with the current SH and LOS, and is a bit more elegant internally.

andrewpaulreeves avatar Mar 31 '22 12:03 andrewpaulreeves